Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Audio Log Crash For Titles Under 4039 #1824

Merged
merged 3 commits into from
Feb 2, 2020

Conversation

RadWolfie
Copy link
Member

Three changes has been made to improve log output plus fix a verbose crash with titles under 4039 build.

  • Add WAVEFORMATEXTENSIBLE struct to logging file
  • Fix audio log crash from titles below 4039 build
  • Add LOGRENDER_MEMBER_ARRAY_TYPE feature to logging file
    working example: .lpMixBinVolumePairs
     [0x5080] DSBUFFERDirectSoundCreateBuffer(
        pdsbd                : 0x0943F1B4 -> X_DSBUFFERDESC* {
        .dwSize               : 18
        .dwFlags              : (DSBCAPS_FLAG)0x000400A0 = XTL_DSBCAPS_CTRLFREQUENCY|XTL_DSBCAPS_CTRLVOLUME|XTL_DSBCAPS_LOCDEFER
        .dwBufferBytes        : 0
        .lpwfxFormat          : 0x0943F1A0 -> WAVEFORMATEX* {
        .wFormatTag           : (WAVEFORMAT_TAG)0x00000001 = WAVE_FORMAT_PCM
        .nChannels            : (WAVEFORMAT_CHANNEL)0x00000002 = WFC_STEREO
        .nSamplesPerSec       : ABE0
        .nAvgBytesPerSec      : 2AF80
        .nBlockAlign          : 4
        .wBitsPerSample       : 10
        .cbSize               : 0}
        .lpMixBinsOutput      : 0x00179C28 -> X_DSMIXBINS* {
        .dwCount              : 8
        .lpMixBinVolumePairs  : 0x00179BE8 -> X_DSMIXBINVOLUMEPAIR* {
        .lpMixBinVolumePairs[0]: {
        .dwMixBin             : 0
        .lVolume              : 0}
        .lpMixBinVolumePairs[1]: {
        .dwMixBin             : 1
        .lVolume              : 0}
        .lpMixBinVolumePairs[2]: {
        .dwMixBin             : 2
        .lVolume              : 0}
        .lpMixBinVolumePairs[3]: {
        .dwMixBin             : 2
        .lVolume              : 0}
        .lpMixBinVolumePairs[4]: {
        .dwMixBin             : 3
        .lVolume              : 0}
        .lpMixBinVolumePairs[5]: {
        .dwMixBin             : 3
        .lVolume              : 0}
        .lpMixBinVolumePairs[6]: {
        .dwMixBin             : 4
        .lVolume              : 0}
        .lpMixBinVolumePairs[7]: {
        .dwMixBin             : 5
        .lVolume              : 0}}}
        .dwInputMixBin        : 0}
      OUT ppBuffer           : 0x00414A44
     );
    

@LukeUsher LukeUsher merged commit 81297c5 into Cxbx-Reloaded:develop Feb 2, 2020
@RadWolfie RadWolfie deleted the fix-audio-log-crash branch February 2, 2020 17:19
@RadWolfie RadWolfie added the sound APU and/or game sound related label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sound APU and/or game sound related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants