Wrap old libloc with GPSSHIM. Seems to fix GPS reboots but needs more tes

[kalltkaffe]

For HCDRJacob,

the new libloc api (in Gingerbread) crashes on Blades (at least on Gen2 Blades) and I suspect that it expects stuff in the kernel that is present in 2.6.35 but not in our 2.6.32 so instead of trying to find out what I switched to GPSSHIM that seems to be a wrapper for the old GPS api.

With the old libloc libs and the wrapper my Gen2 OSF has been rock solid with the GPS since this morning but more testing will be needed to be really sure it helps but I think there is a good chance that it will work fine.

I've posted just the new libs here if you want to try them out before merging the commit: http://android.modaco.com/index.php?s=&showtopic=337547&view=findpost&p=1683274

[HCDRJacob]

Firstly, this is the wrong way to submit patches.

Secondly, the issue is fixed. I was going to do this as my next attempt but it works fine now without this. Users with issues need to wipe.

[kalltkaffe]

What is the right way to submit patches?

[kalltkaffe]

I don't think I had all the latest commits from this repo: https://github.com/CyanogenMod/android_hardware_qcom_gps/commits/gingerbread/
Propably why I was still getting the GPS reboots or perhaps I just needed to wipe?
Seems OK now with N57 and a full wipe.
I'm closing this as it seems it wasn't needed.

[HCDRJacob]

For future reference, Gerrit (review.cyanogenmod.com) is the correct way. There are some instructions on our wiki.

[kalltkaffe]

Thanks for the info.

[kalltkaffe]

Jacob, perhaps wrapping the old libs still is the better solution. An other user reported a strange thing that I was able to reproduce on N57. I also compiled whole CM7 again after a repo sync but the issue is still there.

Try this:

• Reboot the phone
• After reboot start the latest version of Google Maps as the first app you start.
• Keep an eye on the GPS icon as you wait for the first fix.
  For me one of two things happens:
• The whole phone reboots (happens perhaps 1 out of 5 or 1 out of 10 times)
• The GPS icon goes missing for a couple of seconds then reappear and after a few more seconds it gets the fix and GPS works fine.

Now if I do the same with the GPSSHIM method none of the above happens. Could you try and see if you also can reproduce this?