Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio: Add support for tunnel mode recording and compress voip #9

Closed
wants to merge 88 commits into from

Conversation

MetalDroid
Copy link

Hello friend, I would like to inform you that there is a patch that would be interesting to do the merge.

Please you can check this link?: http://review.cyanogenmod.org/#/c/60517/

Thank you!

KonstaT and others added 6 commits March 10, 2014 09:11
Change-Id: Ifd51ae0520b21132eae201db8b3fda4afa3762a7
msm7627a family of chipsets supports only one input frame at
one time. camera expects the input frame to be released before
sending another frame. so send one input buffer and available
output bufefrs to video encoder component. Release the input
buffer to camera (to get another frame) after receiving input
frame done callback from video encoder component.

Change-Id: I8fbc911f046ff7e2a3047dd65d8c09ac2d8608e2
Enable by setting TARGET_QCOM_LEGACY_OMX := true in BoardConfig.mk.

This is a combination of 7 commits.

commit ff56048
Author: Alexey Shavykin <ganster0x29@gmail.com>
Date:   Sun Oct 28 22:46:34 2012 +0200

    Added support legacy Qualcomm OpenMAX IL libs for MSM7x27

    Change-Id: I63e68e63fce955fef52813360032f5e8e90a4b92

commit 27cf702
Author: Ganster41 <ganster0x29@gmail.com>
Date:   Mon Nov 19 15:35:36 2012 +0200

    Correct gralloc usage flags for renderer

commit 3feab89
Author: Conn O'Griofa <connogriofa@gmail.com>
Date:   Fri Jan 4 00:31:13 2013 -0200

    Fix legacy OMX encoders

    Ensure that a valid frame_rate is passed to the encoder, otherwise
    encoding will fail.

    Change-Id: Iaaa298496755ff405e393120973d1ed782f5d8f4

commit f03627b
Author: Grigori Goronzy <greg@blackbox>
Date:   Sat Jan 19 18:26:25 2013 +0100

    Fix alignment and copy size for legacy QCOM OMX

    Change-Id: I6d13c67601da0f0c35d3dd455401f982406cefe3

commit 3e61340
Author: Ganster41 <ganster0x29@gmail.com>
Date:   Sat Jan 5 19:33:44 2013 +0200

    Fixed Gingerbread mmparser using

    Change-Id: Ib931fa6ed4522b5851d42297f929183cf76043fd

commit 25edf98
Author: Ganster41 <ganster0x29@gmail.com>
Date:   Mon Jan 7 19:56:32 2013 +0200

    Try use ExtendedExtractor only if no suitable default extractors available f

    Change-Id: I57a9cc39caee7e3fa2b709ab09cca5629bf81f44

commit 9e98310
Author: Konsta <konsta09@gmail.com>
Date:   Sun Oct 6 20:30:50 2013 +0300

    legacy OMX: use local flags

    Allows use of legacy mmparser without enabling all QCOM A/V
    enhancements that are not supported with legacy OMX blobs.

    Change-Id: Ieccf29ed8036864634ee167c1e21908377516494

Change-Id: Ieccf29ed8036864634ee167c1e21908377516494
Change-Id: I3a1b7b9b6e2646b3ddfb34d7f136589c965b5a29
Change-Id: I3a1b7b9b6e2646b3ddfb34d7f136589c965b5a29
Change-Id: I1ac39a67f5cf9c6f0fd8275dd401e43bf4294922
@cm-gerrit
Copy link

Hi there;

This is an automated reply, to let you know CyanogenMod doesn't merge pull
requests submitted directly to our github.com repositories.

You can submit your change requests through our public review system,
located at http://review.cyanogenmod.org/

That review system is an installation of Google's Gerrit code review.
If you've never interacted with Gerrit before, we also suggest you take
a look at http://wiki.cyanogenmod.org/wiki/Howto:_Gerrit

Thanks!

On Mon, 10 Mar 2014 13:38:39 -0700 you wrote:

Hello friend, I would like to inform you that there is a patch that would be interesting to do the merge.

Please you can check this link?: http://review.cyanogenmod.org/#/c/60517/

Thank you!
You can merge this Pull Request by running:

git pull https://github.com/legaCyMod/android_frameworks_av cm-11.0

Or you can view, comment on it, or merge it online at:

#9

-- Commit Summary --

  • add zte camera parameters
  • qcom-fm: audio: add support for FM feature
  • libstagefright: Enable meta mode for 7x27a video encoder
  • legacy OMX: squashed commit for legacy OMX support
  • support legacy qcom audio variant
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • qcom mr1 fm
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Revert "Avoid jumps to faulty position after seeks"
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0
  • Merge remote-tracking branch 'CyanogenMod/cm-11.0' into cm-11.0

-- File Changes --

M camera/CameraParameters.cpp (5)
M include/camera/CameraParameters.h (5)
M include/media/AudioSystem.h (3)
M include/media/IAudioFlinger.h (3)
M include/media/stagefright/DataSource.h (8)
M media/libmedia/Android.mk (2)
M media/libmedia/AudioSystem.cpp (9)
M media/libmedia/IAudioFlinger.cpp (22)
M media/libmediaplayerservice/Android.mk (5)
M media/libmediaplayerservice/StagefrightRecorder.cpp (10)
M media/libstagefright/Android.mk (11)
M media/libstagefright/AwesomePlayer.cpp (4)
M media/libstagefright/DataSource.cpp (22)
M media/libstagefright/ExtendedCodec.cpp (2)
M media/libstagefright/ExtendedExtractor.cpp (41)
M media/libstagefright/ExtendedUtils.cpp (2)
M media/libstagefright/OMXCodec.cpp (28)
M media/libstagefright/colorconversion/Android.mk (9)
M media/libstagefright/colorconversion/SoftwareRenderer.cpp (66)
M media/libstagefright/include/ExtendedExtractor.h (8)
M media/libstagefright/include/SoftwareRenderer.h (3)
M services/audioflinger/AudioFlinger.cpp (23)
M services/audioflinger/AudioFlinger.h (7)
M services/audioflinger/AudioPolicyService.cpp (65)
M services/audioflinger/AudioPolicyService.h (17)

-- Patch Links --

https://github.com/CyanogenMod/android_frameworks_av/pull/9.patch
https://github.com/CyanogenMod/android_frameworks_av/pull/9.diff


Reply to this email directly or view it on GitHub:
#9

...before removing the code completely. Just use libExtendedExtractor
instead. Turns out it doesn't do much other than dlopen mmparser.

Change-Id: Ic57ac852d9dabbbe2680910432dad95b83d92c66
Set COMMON_GLOBAL_CFLAGS += -DQCOM_LEGACY_CAM_PARAMS
in BoardConfig.mk to enable.
Change-Id: I45314fc75dc5ecd04720c37d544a3583d08659bf
Conflicts:
	media/libstagefright/OMXCodec.cpp
Conflicts:
	include/camera/CameraParametersExtra.h
Conflicts:
	media/libstagefright/Android.mk
	media/libstagefright/OMXCodec.cpp
	media/libstagefright/colorconversion/Android.mk
@cm-gerrit
Copy link

Hi there;

This is an automated reply, to let you know CyanogenMod doesn't merge pull
requests submitted directly to our github.com repositories.

You can submit your change requests through our public review system,
located at http://review.cyanogenmod.org/

That review system is an installation of Google's Gerrit code review.
If you've never interacted with Gerrit before, we also suggest you take
a look at http://wiki.cyanogenmod.org/wiki/Howto:_Gerrit

Thanks!

@cm-gerrit cm-gerrit closed this Feb 9, 2016
semdoc pushed a commit to semdoc/frameworks_av that referenced this pull request Mar 23, 2022
Fix crashes like this:
05-03 20:55:09.029  6254  6254 F DEBUG   :       #00 pc 00000000  <unknown>
05-03 20:55:09.029  6254  6254 F DEBUG   :       CyanogenMod#1 pc 000ec8ab  /system/lib/libcameraservice.so (android::CameraHardwareInterface::notifyCallback(android::hardware::camera::device::V1_0::NotifyCallbackMsg, int, int)+18) (BuildId: 078b8118f1d0503988dc8f86045848d8)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#2 pc 0002e6cd  /system/lib/android.hardware.camera.device@1.0.so (android::hardware::camera::device::V1_0::BsCameraDeviceCallback::notifyCallback(android::hardware::camera::device::V1_0::NotifyCallbackMsg, int, int)+96) (BuildId: a964b5ab287096bfb4e9fb1357483757)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#3 pc 00013783  /system/vendor/lib/camera.device@1.0-impl-htc_msm8960.so (android::hardware::camera::device::V1_0::implementation::CameraDevice::sNotifyCb(int, int, int, void*)+46) (BuildId: 183c013753a49cdceaf880f00b6083b7)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#4 pc 00038b99  /system/vendor/lib/hw/camera.vendor.msm8960.so (android::QCameraStream_preview::processPreviewFrameWithDisplay(mm_camera_ch_data_buf_t*)+128)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#5 pc 000086ff  /system/lib/libmmcamera_interface2.so
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#6 pc 00008855  /system/lib/libmmcamera_interface2.so (mm_camera_msm_data_notify+248)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#7 pc 0000736f  /system/lib/libmmcamera_interface2.so
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#8 pc 000a6b67  /apex/com.android.runtime/lib/bionic/libc.so (__pthread_start(void*)+20) (BuildId: 1c34385a63ae9f807822c87c6b4126d2)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#9 pc 00060101  /apex/com.android.runtime/lib/bionic/libc.so (__start_thread+30) (BuildId: 1c34385a63ae9f807822c87c6b4126d2)

In case of HTC One M7, the nullptr appears because of this call:
https://github.com/AICP/frameworks_av/blob/q10.0/services/camera/libcameraservice/CameraFlashlight.cpp#L528

And while we're on it, lets fix some more possible nullptr's too.

Change-Id: I2f67756d576d62560a2e65af55ab868bfc3e36ba
Signed-off-by: Julian Veit <claymore1298@gmail.com>
semdoc pushed a commit to semdoc/frameworks_av that referenced this pull request Mar 25, 2022
Fix crashes like this:
05-03 20:55:09.029  6254  6254 F DEBUG   :       #00 pc 00000000  <unknown>
05-03 20:55:09.029  6254  6254 F DEBUG   :       CyanogenMod#1 pc 000ec8ab  /system/lib/libcameraservice.so (android::CameraHardwareInterface::notifyCallback(android::hardware::camera::device::V1_0::NotifyCallbackMsg, int, int)+18) (BuildId: 078b8118f1d0503988dc8f86045848d8)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#2 pc 0002e6cd  /system/lib/android.hardware.camera.device@1.0.so (android::hardware::camera::device::V1_0::BsCameraDeviceCallback::notifyCallback(android::hardware::camera::device::V1_0::NotifyCallbackMsg, int, int)+96) (BuildId: a964b5ab287096bfb4e9fb1357483757)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#3 pc 00013783  /system/vendor/lib/camera.device@1.0-impl-htc_msm8960.so (android::hardware::camera::device::V1_0::implementation::CameraDevice::sNotifyCb(int, int, int, void*)+46) (BuildId: 183c013753a49cdceaf880f00b6083b7)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#4 pc 00038b99  /system/vendor/lib/hw/camera.vendor.msm8960.so (android::QCameraStream_preview::processPreviewFrameWithDisplay(mm_camera_ch_data_buf_t*)+128)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#5 pc 000086ff  /system/lib/libmmcamera_interface2.so
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#6 pc 00008855  /system/lib/libmmcamera_interface2.so (mm_camera_msm_data_notify+248)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#7 pc 0000736f  /system/lib/libmmcamera_interface2.so
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#8 pc 000a6b67  /apex/com.android.runtime/lib/bionic/libc.so (__pthread_start(void*)+20) (BuildId: 1c34385a63ae9f807822c87c6b4126d2)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#9 pc 00060101  /apex/com.android.runtime/lib/bionic/libc.so (__start_thread+30) (BuildId: 1c34385a63ae9f807822c87c6b4126d2)

In case of HTC One M7, the nullptr appears because of this call:
https://github.com/AICP/frameworks_av/blob/q10.0/services/camera/libcameraservice/CameraFlashlight.cpp#L528

And while we're on it, lets fix some more possible nullptr's too.

Change-Id: I2f67756d576d62560a2e65af55ab868bfc3e36ba
Signed-off-by: Julian Veit <claymore1298@gmail.com>
semdoc pushed a commit to semdoc/frameworks_av that referenced this pull request Mar 25, 2022
Fix crashes like this:
05-03 20:55:09.029  6254  6254 F DEBUG   :       #00 pc 00000000  <unknown>
05-03 20:55:09.029  6254  6254 F DEBUG   :       CyanogenMod#1 pc 000ec8ab  /system/lib/libcameraservice.so (android::CameraHardwareInterface::notifyCallback(android::hardware::camera::device::V1_0::NotifyCallbackMsg, int, int)+18) (BuildId: 078b8118f1d0503988dc8f86045848d8)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#2 pc 0002e6cd  /system/lib/android.hardware.camera.device@1.0.so (android::hardware::camera::device::V1_0::BsCameraDeviceCallback::notifyCallback(android::hardware::camera::device::V1_0::NotifyCallbackMsg, int, int)+96) (BuildId: a964b5ab287096bfb4e9fb1357483757)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#3 pc 00013783  /system/vendor/lib/camera.device@1.0-impl-htc_msm8960.so (android::hardware::camera::device::V1_0::implementation::CameraDevice::sNotifyCb(int, int, int, void*)+46) (BuildId: 183c013753a49cdceaf880f00b6083b7)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#4 pc 00038b99  /system/vendor/lib/hw/camera.vendor.msm8960.so (android::QCameraStream_preview::processPreviewFrameWithDisplay(mm_camera_ch_data_buf_t*)+128)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#5 pc 000086ff  /system/lib/libmmcamera_interface2.so
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#6 pc 00008855  /system/lib/libmmcamera_interface2.so (mm_camera_msm_data_notify+248)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#7 pc 0000736f  /system/lib/libmmcamera_interface2.so
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#8 pc 000a6b67  /apex/com.android.runtime/lib/bionic/libc.so (__pthread_start(void*)+20) (BuildId: 1c34385a63ae9f807822c87c6b4126d2)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#9 pc 00060101  /apex/com.android.runtime/lib/bionic/libc.so (__start_thread+30) (BuildId: 1c34385a63ae9f807822c87c6b4126d2)

In case of HTC One M7, the nullptr appears because of this call:
https://github.com/AICP/frameworks_av/blob/q10.0/services/camera/libcameraservice/CameraFlashlight.cpp#L528

And while we're on it, lets fix some more possible nullptr's too.

Change-Id: I2f67756d576d62560a2e65af55ab868bfc3e36ba
Signed-off-by: Julian Veit <claymore1298@gmail.com>
semdoc pushed a commit to semdoc/frameworks_av that referenced this pull request Apr 6, 2022
Fix crashes like this:
05-03 20:55:09.029  6254  6254 F DEBUG   :       #00 pc 00000000  <unknown>
05-03 20:55:09.029  6254  6254 F DEBUG   :       CyanogenMod#1 pc 000ec8ab  /system/lib/libcameraservice.so (android::CameraHardwareInterface::notifyCallback(android::hardware::camera::device::V1_0::NotifyCallbackMsg, int, int)+18) (BuildId: 078b8118f1d0503988dc8f86045848d8)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#2 pc 0002e6cd  /system/lib/android.hardware.camera.device@1.0.so (android::hardware::camera::device::V1_0::BsCameraDeviceCallback::notifyCallback(android::hardware::camera::device::V1_0::NotifyCallbackMsg, int, int)+96) (BuildId: a964b5ab287096bfb4e9fb1357483757)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#3 pc 00013783  /system/vendor/lib/camera.device@1.0-impl-htc_msm8960.so (android::hardware::camera::device::V1_0::implementation::CameraDevice::sNotifyCb(int, int, int, void*)+46) (BuildId: 183c013753a49cdceaf880f00b6083b7)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#4 pc 00038b99  /system/vendor/lib/hw/camera.vendor.msm8960.so (android::QCameraStream_preview::processPreviewFrameWithDisplay(mm_camera_ch_data_buf_t*)+128)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#5 pc 000086ff  /system/lib/libmmcamera_interface2.so
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#6 pc 00008855  /system/lib/libmmcamera_interface2.so (mm_camera_msm_data_notify+248)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#7 pc 0000736f  /system/lib/libmmcamera_interface2.so
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#8 pc 000a6b67  /apex/com.android.runtime/lib/bionic/libc.so (__pthread_start(void*)+20) (BuildId: 1c34385a63ae9f807822c87c6b4126d2)
05-03 20:55:09.030  6254  6254 F DEBUG   :       CyanogenMod#9 pc 00060101  /apex/com.android.runtime/lib/bionic/libc.so (__start_thread+30) (BuildId: 1c34385a63ae9f807822c87c6b4126d2)

In case of HTC One M7, the nullptr appears because of this call:
https://github.com/AICP/frameworks_av/blob/q10.0/services/camera/libcameraservice/CameraFlashlight.cpp#L528

And while we're on it, lets fix some more possible nullptr's too.

Change-Id: I2f67756d576d62560a2e65af55ab868bfc3e36ba
Signed-off-by: Julian Veit <claymore1298@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants