Skip to content

Commit

Permalink
SECURITY remove lock pattern from being logged
Browse files Browse the repository at this point in the history
commit Ibc0d5bfcee9673b1bf049bd69be80d2312602a47 made it so that the
lockpattern was loged in logcat as it was entered.
I'm really surprised nobody caught this.
This could also be solved by commenting the code out or just removing the line
without breaking anything.

Patch Set 3: Remove logging

modified:   core/java/com/android/internal/widget/LockPatternView.java

Change-Id: I2544eb11a2b003ef2d303470b19633241867fc29
  • Loading branch information
Gabriel Castro authored and burnsra committed Oct 21, 2012
1 parent d3d85cb commit 56c014f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion core/java/com/android/internal/widget/LockPatternView.java
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,6 @@ private void addCellToPattern(Cell newCell) {
mPatternDrawLookup[newCell.getRow()][newCell.getColumn()] = true;
mPattern.add(newCell);
notifyCellAdded();
Log.v("SMASHER816", "("+newCell.column+", "+newCell.row+")");
}

// helper method to find which cell a point maps to
Expand Down

0 comments on commit 56c014f

Please sign in to comment.