Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

SECURITY remove lock pattern from being logged

commit Ibc0d5bfcee9673b1bf049bd69be80d2312602a47 made it so that the
lockpattern was loged in logcat as it was entered.
I'm really surprised nobody caught this.
This could also be solved by commenting the code out or just removing the line
without breaking anything.

Patch Set 3: Remove logging

modified:   core/java/com/android/internal/widget/LockPatternView.java

Change-Id: I2544eb11a2b003ef2d303470b19633241867fc29
  • Loading branch information...
commit 56c014f289e04c0fd769af55c861b6e7bf7b4280 1 parent d3d85cb
Gabriel Castro authored October 21, 2012 burnsra committed October 21, 2012
1  core/java/com/android/internal/widget/LockPatternView.java
@@ -613,7 +613,6 @@ private void addCellToPattern(Cell newCell) {
613 613
         mPatternDrawLookup[newCell.getRow()][newCell.getColumn()] = true;
614 614
         mPattern.add(newCell);
615 615
         notifyCellAdded();
616  
-        Log.v("SMASHER816", "("+newCell.column+", "+newCell.row+")");
617 616
     }
618 617
 
619 618
     // helper method to find which cell a point maps to

Git Notes

review

Code-Review+1: Robert Burns <burnsra@gmail.com>
Code-Review+2: David van Tonder <david.vantonder@gmail.com>
Verified+1: David van Tonder <david.vantonder@gmail.com>
Submitted-by: David van Tonder <david.vantonder@gmail.com>
Submitted-at: Sun, 21 Oct 2012 06:29:37 -0700
Reviewed-on: http://review.cyanogenmod.com/25214
Project: CyanogenMod/android_frameworks_base
Branch: refs/heads/jellybean

0 notes on commit 56c014f

Please sign in to comment.
Something went wrong with that request. Please try again.