Skip to content

Commit

Permalink
Fix logging level and remove nmea log
Browse files Browse the repository at this point in the history 
Logging level should be 2 by default to
prevent excessive logging by default.
Nmea log print is removed, as it can be
excessive during gps tracking.

Bugs: 29499503 29272976
Change-Id: Ia60295207b6bbbcb24bbede4f1802c0c7a2f2544
  • Loading branch information
@eccopark
Dante Russo authored and eccopark committed Jul 20, 2016
1 parent e0bc79a commit fecc8ce
Show file tree
Hide file tree
Showing 14 changed files with 4 additions and 14 deletions.
2 changes: 1 addition & 1 deletion etc/gps.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ NTP_SERVER=time.gpsonextra.net
# DEBUG LEVELS: 0 - none, 1 - Error, 2 - Warning, 3 - Info
# 4 - Debug, 5 - Verbose
# If DEBUG_LEVEL is commented, Android's logging levels will be used
DEBUG_LEVEL = 3
DEBUG_LEVEL = 2

# Intermediate position report, 1=enable, 0=disable
INTERMEDIATE_POS=0
Expand Down
1 change: 0 additions & 1 deletion loc_api/libloc_api_50001/loc_eng.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,6 @@ void LocEngReportNmea::proc() const {
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %d, mLen);

if (locEng->nmea_cb != NULL)
locEng->nmea_cb(now, mNmea, mLen);
Expand Down
1 change: 0 additions & 1 deletion loc_api/libloc_api_50001/loc_eng_nmea.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ void loc_eng_nmea_send(char *pNmea, int length, loc_eng_data_s_type *loc_eng_dat
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %p, pNmea);
if (loc_eng_data_p->nmea_cb != NULL)
loc_eng_data_p->nmea_cb(now, pNmea, length);
LOC_LOGD("NMEA <%s", pNmea);
Expand Down
2 changes: 1 addition & 1 deletion msm8084/etc/gps.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ NTP_SERVER=time.gpsonextra.net
# DEBUG LEVELS: 0 - none, 1 - Error, 2 - Warning, 3 - Info
# 4 - Debug, 5 - Verbose
# If DEBUG_LEVEL is commented, Android's logging levels will be used
DEBUG_LEVEL = 3
DEBUG_LEVEL = 2

# Intermediate position report, 1=enable, 0=disable
INTERMEDIATE_POS=0
Expand Down
1 change: 0 additions & 1 deletion msm8084/loc_api/libloc_api_50001/loc_eng.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,6 @@ void LocEngReportNmea::proc() const {
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %d, mLen);

if (locEng->nmea_cb != NULL)
locEng->nmea_cb(now, mNmea, mLen);
Expand Down
1 change: 0 additions & 1 deletion msm8084/loc_api/libloc_api_50001/loc_eng_nmea.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ void loc_eng_nmea_send(char *pNmea, int length, loc_eng_data_s_type *loc_eng_dat
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %p, pNmea);
if (loc_eng_data_p->nmea_cb != NULL)
loc_eng_data_p->nmea_cb(now, pNmea, length);
LOC_LOGD("NMEA <%s", pNmea);
Expand Down
2 changes: 1 addition & 1 deletion msm8909/etc/gps.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ NTP_SERVER=time.gpsonextra.net
# DEBUG LEVELS: 0 - none, 1 - Error, 2 - Warning, 3 - Info
# 4 - Debug, 5 - Verbose
# If DEBUG_LEVEL is commented, Android's logging levels will be used
DEBUG_LEVEL = 3
DEBUG_LEVEL = 2

# Intermediate position report, 1=enable, 0=disable
INTERMEDIATE_POS=0
Expand Down
1 change: 0 additions & 1 deletion msm8909/loc_api/libloc_api_50001/loc_eng.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,6 @@ void LocEngReportNmea::proc() const {
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %d, mLen);

if (locEng->nmea_cb != NULL)
locEng->nmea_cb(now, mNmea, mLen);
Expand Down
1 change: 0 additions & 1 deletion msm8909/loc_api/libloc_api_50001/loc_eng_nmea.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ void loc_eng_nmea_send(char *pNmea, int length, loc_eng_data_s_type *loc_eng_dat
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %p, pNmea);
if (loc_eng_data_p->nmea_cb != NULL)
loc_eng_data_p->nmea_cb(now, pNmea, length);
LOC_LOGD("NMEA <%s", pNmea);
Expand Down
1 change: 0 additions & 1 deletion msm8960/loc_api/libloc_api_50001/loc_eng.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,6 @@ void LocEngReportNmea::proc() const {
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %d, mLen);
locEng->nmea_cb(now, mNmea, mLen);
}
inline void LocEngReportNmea::locallog() const {
Expand Down
1 change: 0 additions & 1 deletion msm8960/loc_api/libloc_api_50001/loc_eng_nmea.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ void loc_eng_nmea_send(char *pNmea, int length, loc_eng_data_s_type *loc_eng_dat
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %p, pNmea);
loc_eng_data_p->nmea_cb(now, pNmea, length);
LOC_LOGD("NMEA <%s", pNmea);
}
Expand Down
2 changes: 1 addition & 1 deletion msm8996/etc/gps.conf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ NTP_SERVER=time.izatcloud.net
# DEBUG LEVELS: 0 - none, 1 - Error, 2 - Warning, 3 - Info
# 4 - Debug, 5 - Verbose
# If DEBUG_LEVEL is commented, Android's logging levels will be used
DEBUG_LEVEL = 3
DEBUG_LEVEL = 2

# Intermediate position report, 1=enable, 0=disable
INTERMEDIATE_POS=0
Expand Down
1 change: 0 additions & 1 deletion msm8996/loc_api/libloc_api_50001/loc_eng.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,6 @@ void LocEngReportNmea::proc() const {
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %d, mLen);

if (locEng->nmea_cb != NULL)
locEng->nmea_cb(now, mNmea, mLen);
Expand Down
1 change: 0 additions & 1 deletion msm8996/loc_api/libloc_api_50001/loc_eng_nmea.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ void loc_eng_nmea_send(char *pNmea, int length, loc_eng_data_s_type *loc_eng_dat
struct timeval tv;
gettimeofday(&tv, (struct timezone *) NULL);
int64_t now = tv.tv_sec * 1000LL + tv.tv_usec / 1000;
CALLBACK_LOG_CALLFLOW("nmea_cb", %p, pNmea);
if (loc_eng_data_p->nmea_cb != NULL)
loc_eng_data_p->nmea_cb(now, pNmea, length);
LOC_LOGD("NMEA <%s", pNmea);
Expand Down

0 comments on commit fecc8ce

Please sign in to comment.