The current update process is not safe. TLDR: if the update code actuall... #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally runs - then an attacker who can MITM a victim can hijack and subvert the current update mechanism. This commit relates to the issue found at ChainsDD#52 . Signed-off-by: David <db@d1b.org>
…ore appropriate (when preventing the update from running). Signed-off-by: David <db@d1b.org>
|
Please submit through gerrit. http://review.cyanogenmod.org More information on submission through gerrit can be found at http://wiki.cyanogenmod.org/w/Doc:_using_gerrit |
|
@jeagoss upstream has already merged a fix for this issue. |
|
It was an automated message through my 'Close All The Requests' scripts. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...y runs - then an attacker who can MITM a victim can hijack and subvert the current update mechanism.
This commit relates to the issue found at ChainsDD#52 .
Signed-off-by: David db@d1b.org