forked from koush/android_system_core
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DO NOT MERGE libutils/Unicode.cpp: Correct length computation and add…
… checks for utf16->utf8 Inconsistent behaviour between utf16_to_utf8 and utf16_to_utf8_length is causing a heap overflow. Correcting the length computation and adding bound checks to the conversion functions. CYNGNOS-3235 (cherry picked from commit c4966a3) Change-Id: Idfb0eb29b305678608586d25c2f372146569ad39 Bug: 29250543 (cherry picked from commit 2806397)
- Loading branch information
Sergio Giro
authored and
Jessica Wagantall
committed
Sep 12, 2016
1 parent
82f218b
commit 2cdbe55
Showing
4 changed files
with
46 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cdbe55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwagantall
I'm getting errors when compiling external/mm-dash/libdashplayer and libmediaplayerservice, with cherry-picked commits from yesterday.
Commits:
2cdbe55
(DO NOT MERGE libutils/Unicode.cpp: Correct length computation and add checks for utf16->utf8)
CyanogenMod/android_frameworks_av@9b5caa8
(DO NOT MERGE libmediaplayerservice: Add bound checks to utf16_to_utf8)
Hope that I will help bring up the solution to this.
2cdbe55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also have build error, on media-caf (msm8960 branch)
2cdbe55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://review.cyanogenmod.org/162174