Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 enhancement/verbesserung des codes #7

Merged
merged 4 commits into from
May 2, 2018

Conversation

Cy-bec
Copy link
Contributor

@Cy-bec Cy-bec commented Apr 26, 2018

@ni431str Schau mal drüber ob du die Methoden GetPossibleMovesConquared und MovePiece gut verstehst

sollte jetzt gut aussehen :D

@Cy-bec Cy-bec requested a review from ni431str April 26, 2018 14:02
@ghost ghost assigned Cy-bec Apr 26, 2018
@ghost ghost added the in review label Apr 26, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 54

  • 75 of 84 (89.29%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 96.291%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/de/htwg/se/Shogi/controller/controllerComponent/controllerBaseImpl/Controller.scala 3 5 60.0%
src/main/scala/de/htwg/se/Shogi/model/boardComponent/boardBaseImpl/Board.scala 5 7 71.43%
src/main/scala/de/htwg/se/Shogi/controller/controllerComponent/controllerBaseImpl/PlayerRounds.scala 55 60 91.67%
Totals Coverage Status
Change from base Build 44: -0.4%
Covered Lines: 649
Relevant Lines: 674

💛 - Coveralls

@ni431str ni431str merged commit eec4fd4 into master May 2, 2018
@ghost ghost removed the in review label May 2, 2018
@Cy-bec Cy-bec mentioned this pull request May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants