Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Fall back Default image wasn't being loaded. #46

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Bugfix: Fall back Default image wasn't being loaded. #46

merged 6 commits into from
Aug 30, 2022

Conversation

n8-dev
Copy link
Contributor

@n8-dev n8-dev commented Jun 17, 2022

Issues fixed:

  • DefaultPageSocialImage
  • Added twitter:image to template for when DefaultPageSocialImage is used

@n8-dev n8-dev mentioned this pull request Jun 17, 2022
Closed
@mooror
Copy link

mooror commented Jul 19, 2022

I have also come across this issue in our installs as well.

Can someone look into merging this and making another release?

@n8-dev
Copy link
Contributor Author

n8-dev commented Aug 28, 2022

Hi @samthejarvis I see you have actioned other merges and commits in this repo; any chance you could look at this?

samthejarvis
samthejarvis reviewed Aug 29, 2022
View reviewed changes
Copy link
Contributor

@samthejarvis samthejarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Could the vendor-specific items be removed from the .gitignore?

@n8-dev
Copy link
Contributor Author

n8-dev commented Aug 30, 2022

Is it needed? @samthejarvis they're just standard details from using two very common IDEs
(VsCode and any of the JetBrains tools)

@samthejarvis
Copy link
Contributor

Generally prefer these are ignored locally for this purpose but not too precious about it 👍

@samthejarvis samthejarvis merged commit 0b7c401 into Cyber-Duck:develop Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samthejarvis samthejarvis samthejarvis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n8-dev @mooror @samthejarvis