Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not close the done_fifo and wait on the service for done signal #59

Merged
merged 1 commit into from
Feb 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions assemblyline_service_client/task_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -489,12 +489,10 @@ def stop(self):

super().stop()

self.log.info("Closing named pipes...")
if self.done_fifo is not None:
try:
self.done_fifo.close()
except BrokenPipeError:
pass
# We only want to close the tasking pipe to trigger the service to stop waiting.
# We need to wait on the service to finish the current task and close our done_fifo
# pipe so that it can be sent back to the system.
self.log.info("Closing task_fifo named pipes...")
if self.task_fifo is not None:
try:
self.task_fifo.close()
Expand Down