Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: decouple license detection logic #118

Merged
merged 6 commits into from
Feb 4, 2022
Merged

refactor: decouple license detection logic #118

merged 6 commits into from
Feb 4, 2022

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jan 29, 2022

Addresses #117

Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added the enhancement New feature or request label Jan 29, 2022
@nscuro nscuro added this to the v1.2.0 milestone Jan 29, 2022
@nscuro
Copy link
Member Author

nscuro commented Jan 29, 2022

@imjasonh I went with decoupling the code using go-license-detector into a different package. Different module would be nice, but I don't see myself dealing with multiple modules at this point. As you noted in #100, it becomes fairly unwieldy.

Means this will only address your binary size concerns, but not the potential issue of tooling complaining about modules you're not consuming. I'm leaning towards blaming the tooling for this though. 😄

Either way, as expected, the current solution will reduce the binary size by a little over 4mb:

2022-01-29 20_12_05- edx_issue-117

2022-01-29 20_13_28- edx_issue-117

Would this be a compromise you're willing to take?

Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro marked this pull request as ready for review February 4, 2022 17:14
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro merged commit ac4a859 into main Feb 4, 2022
@nscuro nscuro deleted the issue-117 branch February 4, 2022 17:20
@nscuro nscuro mentioned this pull request Feb 5, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant