-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Metadata:Manufacture and Licenses #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work @flashfishgit, I think we can improve the user experience by adding some custom DSL into the task.
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/CycloneDX/cyclonedx-gradle-plugin/310.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/CycloneDX/cyclonedx-gradle-plugin/310.diff | git apply Once you're satisfied, commit and push your changes in your project. Footnotes |
Thanks for your fast response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Could you fix conflicts ?
6014a07
to
ad29259
Compare
hello @glefloch , |
Signed-off-by: mso <mso@sbs.co.at>
Signed-off-by: mso <mso@sbs.co.at>
Signed-off-by: mso <mso@sbs.co.at>
Signed-off-by: mso <mso@sbs.co.at>
remove // Signed-off-by: mso <mso@sbs.co.at>
Signed-off-by: Author Name <marco.soellinger@gmx.at> Signed-off-by: mso <mso@sbs.co.at>
Signed-off-by: Author Name <marco.soellinger@gmx.at> Signed-off-by: mso <mso@sbs.co.at>
@flashfishgit I rebased your work locally but I'm not able to push my updates. Could you check the box allowing me to update your branch ? This should be located in the pull request settings. |
Actually it's ok. I was able to push my rebase. |
thanks for this work @flashfishgit |
Hello,
I noticed there is no way to include Manufacture and Licenses in the Metadata. (https://cyclonedx.org/docs/1.4/json/#metadata.)
This pull-request adds a way to manually include these information, by passing the from the build.gradle
I also added two Tests and included my Documentation in the Read.me File.