Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not normalize Models.Component.properties with CDX-spec-1.2 #152

Closed
jkowalleck opened this issue Aug 4, 2022 · 1 comment · Fixed by #153
Closed

do not normalize Models.Component.properties with CDX-spec-1.2 #152

jkowalleck opened this issue Aug 4, 2022 · 1 comment · Fixed by #153
Labels
bug Something isn't working schema 1.2 related to CycloneDX spec v1.2

Comments

@jkowalleck
Copy link
Member

CycloneDX specification 1.2 does not know the properties of a component.
see https://github.com/CycloneDX/specification/tree/master/schema

Current status: the JSON- and XML-normalizer will render the Models.Component.properties with spec.1.2
This might not seam like a big issue, as JSON- and XML-schema allow custom elements.

❌ BUT the JSON-strict schema does not allow any unexpected elements.
@jkowalleck jkowalleck added bug Something isn't working schema 1.2 related to CycloneDX spec v1.2 labels Aug 4, 2022
@jkowalleck jkowalleck pinned this issue Aug 4, 2022
jkowalleck added a commit that referenced this issue Aug 4, 2022
@jkowalleck
fix normalixer of Models.Component.properties with CDX-1.2
af01730 
* Fixed
  * JSON- and XML-Normalizer no longer render `Models.Component.properties`
    with [_CycloneDX_ Specification][CycloneDX-specification]-1.2.
    ([#152] via [#153])
  * XML-Normalizer now has the correct order/position of rendered `Models.Component.properties`. (via [#153])

[#152]: #152
[#153]: #153
@jkowalleck jkowalleck mentioned this issue Aug 4, 2022
Merged
jkowalleck added a commit that referenced this issue Aug 4, 2022
@jkowalleck
fix normalixer of Models.Component.properties with CDX-1.2
e160671 
* Fixed
  * JSON- and XML-Normalizer no longer render `Models.Component.properties`
    with [_CycloneDX_ Specification][CycloneDX-specification]-1.2.
    ([#152] via [#153])
  * XML-Normalizer now has the correct order/position of rendered `Models.Component.properties`. (via [#153])

[#152]: #152
[#153]: #153
[CycloneDX-specification]: https://github.com/CycloneDX/specification/tree/main/schema
jkowalleck added a commit that referenced this issue Aug 4, 2022
@jkowalleck
fix normalixer of Models.Component.properties with CDX-1.2
2b365dc 
* Fixed
  * JSON- and XML-Normalizer no longer render `Models.Component.properties`
    with [_CycloneDX_ Specification][CycloneDX-specification]-1.2.
    ([#152] via [#153])
  * XML-Normalizer now has the correct order/position of rendered `Models.Component.properties`. (via [#153])

[#152]: #152
[#153]: #153
[CycloneDX-specification]: https://github.com/CycloneDX/specification/tree/main/schema

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Aug 4, 2022
@jkowalleck
fix normalixer of Models.Component.properties with CDX-1.2 (#153)
7cc3a3e 
* Fixed
  * JSON- and XML-Normalizer no longer render `Models.Component.properties`
    with [_CycloneDX_ Specification][CycloneDX-specification]-1.2.
    ([#152] via [#153])
  * XML-Normalizer now has the correct order/position of rendered `Models.Component.properties`. (via [#153])

[#152]: #152
[#153]: #153
[CycloneDX-specification]: https://github.com/CycloneDX/specification/tree/main/schema

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck unpinned this issue Aug 4, 2022
@jkowalleck
Copy link
Member Author

closed via #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working schema 1.2 related to CycloneDX spec v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix normalixer of Models.Component.properties with CDX-1.2 CycloneDX/cyclonedx-javascript-library
1 participant
@jkowalleck