Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix normalixer of Models.Component.properties with CDX-1.2 #153

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Aug 4, 2022

closes #152

  • Fixed
    • JSON- and XML-Normalizer no longer render Models.Component.properties with CycloneDX Specification-1.2. (#152 via #153)
    • XML-Normalizer now has the correct order/position of rendered Models.Component.properties. (via #153)

@jkowalleck jkowalleck added bug Something isn't working schema 1.2 related to CycloneDX spec v1.2 labels Aug 4, 2022
@jkowalleck jkowalleck requested a review from a team as a code owner August 4, 2022 11:18
jkowalleck added a commit that referenced this pull request Aug 4, 2022
* Fixed
  * JSON- and XML-Normalizer no longer render `Models.Component.properties`
    with [_CycloneDX_ Specification][CycloneDX-specification]-1.2.
    ([#152] via [#153])
  * XML-Normalizer now has the correct order/position of rendered `Models.Component.properties`. (via [#153])

[#152]: #152
[#153]: #153
[CycloneDX-specification]: https://github.com/CycloneDX/specification/tree/main/schema
@jkowalleck jkowalleck force-pushed the fix-component-properties-spec1.2 branch from af01730 to e160671 Compare August 4, 2022 11:19
* Fixed
  * JSON- and XML-Normalizer no longer render `Models.Component.properties`
    with [_CycloneDX_ Specification][CycloneDX-specification]-1.2.
    ([#152] via [#153])
  * XML-Normalizer now has the correct order/position of rendered `Models.Component.properties`. (via [#153])

[#152]: #152
[#153]: #153
[CycloneDX-specification]: https://github.com/CycloneDX/specification/tree/main/schema

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the fix-component-properties-spec1.2 branch from e160671 to 2b365dc Compare August 4, 2022 11:23
@jkowalleck jkowalleck merged commit 7cc3a3e into main Aug 4, 2022
@jkowalleck jkowalleck deleted the fix-component-properties-spec1.2 branch August 4, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working schema 1.2 related to CycloneDX spec v1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not normalize Models.Component.properties with CDX-spec-1.2
1 participant