Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude extraneous packages from BoM file #13

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Exclude extraneous packages from BoM file #13

merged 2 commits into from
Mar 28, 2019

Conversation

anush-cr
Copy link
Contributor

read-installed traverses all folders within the node_modules folder and marks any devDependencies as extraneous when the dev option is to false (this is also the default value). Since the current expectation from this module is to not include any devDependencies regardless of whether they are in the node_modules directory, I've created this PR to exclude all extraneous packages.

If there is a need to have devDependencies as part of the BoM, a new flag should be introduced that would set the dev option of read-installed to true,

@stevespringett
Copy link
Member

Thanks for the PR

@stevespringett stevespringett merged commit 3cfaa95 into CycloneDX:master Mar 28, 2019
@lock
Copy link

lock bot commented Jun 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants