Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move "CORE" to own package #87

Closed
10 tasks done
jkowalleck opened this issue Jun 6, 2021 · 0 comments · Fixed by #127
Closed
10 tasks done

move "CORE" to own package #87

jkowalleck opened this issue Jun 6, 2021 · 0 comments · Fixed by #127
Milestone

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Jun 6, 2021

see https://github.com/CycloneDX/cyclonedx-php-composer/milestone/5

impact

as long as all interfaces/namespaces stay untouched, this would not be a breaking change.

The new external package/library is a one-to-one copy of the original code from this project, which now is a dependency/required of this project. So usage/leverage of the original code is still possible without any changes for third parties.

benefit:

  • core can evolve independently from the plugin: features/bugfixes are independent from plugin's release cycle

acc / crit:


steps in order

  1. create new repo see https://github.com/CycloneDX/cyclonedx-php-library
  2. copy the code to new repo & test it
  3. make repo a composer package
  4. publsh at https://packagist.org
  5. tag the new package
  6. remove now "external"/duplicated files from plugin-repo - via removed core lib from src #127
  7. require the new package in the plugin package with an appropriate version range - via removed core lib from src #127
  8. have the usage as a lib merged to master

possible followups: / ideas for the extracketd package:

@jkowalleck jkowalleck changed the title move non-plugin logic to own package move "CORE" logic to own package Jul 5, 2021
@jkowalleck jkowalleck changed the title move "CORE" logic to own package move "CORE" to own package Jul 25, 2021
@jkowalleck jkowalleck pinned this issue Sep 11, 2021
jkowalleck added a commit that referenced this issue Oct 7, 2021
see issue #87
core lib moved to https://github.com/CycloneDX/cyclonedx-php-library

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Oct 7, 2021
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Oct 7, 2021
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Oct 7, 2021
see issue #87
core lib moved to https://github.com/CycloneDX/cyclonedx-php-library

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Oct 7, 2021
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Oct 7, 2021
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Oct 7, 2021
see issue #87
core lib moved to https://github.com/CycloneDX/cyclonedx-php-library

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Oct 7, 2021
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Oct 7, 2021
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Oct 7, 2021
* Changed
  * Core library
    * Was moved to an own package: https://packagist.org/packages/cyclonedx/cyclonedx-library
      The new external package/library is a one-to-one copy of the original code from this project, which now is a dependency/required of this project. So usage/leverage of the original code is still possible without any changes for third parties.
      See [#87] for details.

[#87]: #87
jkowalleck added a commit that referenced this issue Oct 7, 2021
* Changed
  * Core library
    * Was moved to an own package: https://packagist.org/packages/cyclonedx/cyclonedx-library
      The new external package/library is a one-to-one copy of the original code from this project, which now is a dependency/required of this project. So usage/leverage of the original code is still possible without any changes for third parties.
      See [#87] for details.

[#87]: #87
@jkowalleck jkowalleck unpinned this issue Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant