Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list-like are not nullable but empty objects/lists per default #66

Closed
jkowalleck opened this issue Feb 4, 2022 · 0 comments · Fixed by #131
Closed

list-like are not nullable but empty objects/lists per default #66

jkowalleck opened this issue Feb 4, 2022 · 0 comments · Fixed by #131
Assignees
@jkowalleck
Labels
breaking change
Milestone
v2

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Feb 4, 2022 •
edited
Loading

to improve typing, all list-like elements become lists. always.
all map-like become maps. always.
no null values anymore.

motivation: simply call myStructure->get<ListLike>()->append() - no check needed, whether the get<ListLike>() returned null or something ...

this is considered a breaking change, as return types might change.

for renaming, see #66
@jkowalleck jkowalleck added this to the v2 milestone Feb 4, 2022
@jkowalleck jkowalleck changed the title lists are not nullable but empty lists per default lists-like are not nullable but empty objects/lists per default Feb 4, 2022
@jkowalleck jkowalleck changed the title lists-like are not nullable but empty objects/lists per default list-like are not nullable but empty objects/lists per default Feb 4, 2022
@jkowalleck jkowalleck mentioned this issue Sep 17, 2022
Merged
11 tasks
@jkowalleck jkowalleck self-assigned this Sep 17, 2022
jkowalleck added a commit that referenced this issue Sep 25, 2022
@jkowalleck
Merge pull request #131 from CycloneDX/repos-not-nullable
019ac0a 
- make aggregation properties non-nullable #66 
- rename some structures #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
breaking change
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

make aggregation properties non-nullable CycloneDX/cyclonedx-php-library
1 participant
@jkowalleck