Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make aggregation properties non-nullable #131

Merged
merged 24 commits into from Sep 25, 2022
Merged

make aggregation properties non-nullable #131

merged 24 commits into from Sep 25, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Sep 17, 2022 •
edited

fixes #66
parts of #133

  • make aggregation properties non-nullable
  • rename properties to match the CycloneDX spec - rename some stuff #133
  • rename Repository to Collection when appropriate. - as of rename some stuff #133
  • adjust normalizers to ignore nulls
  • make bom.metadata a non-nullable - it is a compound
  • write history - document api chnages
  • fix all usages
  • fix normalizers especially
  • bring back the tests for the several LicenseNormalizers
  • bring back the tests for the bom.externalReferences nnormalizer
  • have 100% test coverage, again.

@jkowalleck jkowalleck added this to the v2 milestone Sep 17, 2022
@jkowalleck jkowalleck force-pushed the repos-not-nullable branch 6 times, most recently from eb2215c to 0182c51 Compare September 17, 2022 20:46
@jkowalleck
make aggregation properties non-nullable
c0ca5af 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
renamed MetaData -> Metadata
9df7745 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wrote HISTORY
10069d4 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
streamline repositories -> collections
8747bfb 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
docs
400fd0e 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
history
4338fba 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
HISTORY
828ad59 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
7e39206 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
1b15a62 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
2f53c58 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
f59d701 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
54776cf 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
d4b746a 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
dd88c33 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
7c85329 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
4e17ade 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
1dbea4f 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
05a004f 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
8c732cb 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
52f8444 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
0a14a7b 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
renamed internal "AbstractNormalizer" -> "_BaseNormalizer"
8457248 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
56ac1c0 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
wip
82cf715 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review September 25, 2022 09:25
@jkowalleck jkowalleck requested a review from a team as a code owner September 25, 2022 09:25
@jkowalleck jkowalleck merged commit 019ac0a into master Sep 25, 2022
@jkowalleck jkowalleck deleted the repos-not-nullable branch September 25, 2022 09:26
jkowalleck added a commit that referenced this pull request Nov 2, 2022
@jkowalleck
post-fixes from #131
7645f9b 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

list-like are not nullable but empty objects/lists per default
1 participant
@jkowalleck