Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native php enum #204

Merged
merged 8 commits into from
Feb 4, 2023
Merged

native php enum #204

merged 8 commits into from
Feb 4, 2023

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Feb 4, 2023 •
edited
Loading

fixes #140

  • raise php requirement from 8.0 to 8.1
  • convert all enum classes to be native PHP enums

@jkowalleck
require php8.1
a86bbd7 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
migrate code to php81
2f4779c 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
all native enums
da2d976 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
code style
38d0f3d 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added this to the v2 milestone Feb 4, 2023
@jkowalleck jkowalleck requested a review from a team as a code owner February 4, 2023 14:57
@jkowalleck
CI: min version PHP8.1
ae5940b 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added enhancement New feature or request CI Continuous Integration QA Quality Assurance labels Feb 4, 2023
@jkowalleck jkowalleck marked this pull request as draft February 4, 2023 15:00
@jkowalleck
HISTORY
f77a964 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
HISTORY
b7f7fdd 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
revert for backward compat
8cacbc2 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review February 4, 2023 15:45
@jkowalleck jkowalleck merged commit 9a83010 into master Feb 4, 2023
@jkowalleck jkowalleck deleted the php81_enums branch February 4, 2023 15:48
@jkowalleck jkowalleck changed the title native php eunis native php enum Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change CI Continuous Integration enhancement New feature or request QA Quality Assurance
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

[PHP8.1] use native enums
1 participant
@jkowalleck