Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerhub release: use org secrets #271

Closed
2 tasks done
jkowalleck opened this issue Dec 1, 2021 · 4 comments
Closed
2 tasks done

dockerhub release: use org secrets #271

jkowalleck opened this issue Dec 1, 2021 · 4 comments

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Dec 1, 2021

as of CycloneDX/cyclonedx-node-module#192 (comment)

coderpatros needs to be changed to $DOCKERHUB_USERNAME
$DOCKER_TOKEN needs to be changed to $DOCKERHUB_TOKEN.

Both DOCKERHUB_USERNAME and DOCKERHUB_TOKEN are secrets defined at the GitHub organization level. I assume DOCKER_TOKEN is likely unique to this repo and should be deleted in favor of the organizational secrets.


tasks

@stevespringett
Copy link
Member

FYI. These should likely be changed as well.
PYPI_TOKEN (organization)
PYPI_API_TOKEN (repo)

jkowalleck added a commit that referenced this issue Dec 1, 2021
as of #271

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Copy link
Member Author

jkowalleck added a commit that referenced this issue Dec 1, 2021
@jkowalleck
Copy link
Member Author

@stevespringett could you remove unused repo secrets?

  • PYPI_API_TOKEN
  • DOCKER_TOKEN

@stevespringett
Copy link
Member

PYPI_API_TOKEN and DOCKER_TOKEN secrets have been deleted from the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants