Merge pull request #78 from zadykian/fix/param-without-value-error

error 'Index was outside the bounds of the array'
Cysharp · Jul 25, 2022 · 39e6758 · 39e6758
2 parents 5c3eb63 + 7817814
commit 39e6758
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/ConsoleAppFramework/ConsoleAppEngine.cs b/src/ConsoleAppFramework/ConsoleAppEngine.cs
@@ -489,6 +489,11 @@ bool TryGetInvokeArguments(ParameterInfo[] parameters, string?[] args, int argsO
                     }
                     else
                     {
+                        if (args.Length <= i)
+                        {
+                            throw new ArgumentException($@"Value for parameter ""{key}"" is not provided.");
+                        }
+
                         var value = args[i];
                         dict.Add(key, new OptionParameter { Value = value });
                         i++;

diff --git a/tests/ConsoleAppFramework.Tests/Integration/SingleCommandTest.Options.cs b/tests/ConsoleAppFramework.Tests/Integration/SingleCommandTest.Options.cs
@@ -199,6 +199,15 @@ public void OptionalBoolAndRequiredOtherOption_NoArgs_1()
             console.Output.Should().Contain("Hello Cysharp");
         }
 
+        [Fact]
+        public void Attempt_To_Call_Without_Parameter_Value()
+        {
+            using var console = new CaptureConsoleOutput();
+            var args = new[] { "--name" };
+            Host.CreateDefaultBuilder().RunConsoleAppFrameworkAsync<CommandTests_Single_OptionalBoolAndRequiredOtherOption_NoArgs>(args);
+            console.Output.Should().Contain(@"Value for parameter ""name"" is not provided.");
+        }
+
         public class CommandTests_Single_OptionalBoolAndRequiredOtherOption_NoArgs : ConsoleAppBase
         {
             public void Hello(string name, bool hello = false) => Console.WriteLine($"{(hello ? "Hello" : "Konnichiwa")} {name}");