Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grammar of exceptions #111

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Improve grammar of exceptions #111

merged 1 commit into from
Jun 3, 2024

Conversation

xPaw
Copy link
Contributor

@xPaw xPaw commented Jun 3, 2024

I've noticed the value printed in ThrowArgumentParseFailed may not be correct in some cases, like when TryIncrementIndex fails, it will print the argument name itself, rather than the value (because there isn't one). Maybe this should be special cased to a new exception like Argument '{argumentName}' requires a value, but none was specified.?

@neuecc
Copy link
Member

neuecc commented Jun 3, 2024

Thanks!
I agree, while the current solution was a bit of a quick fix, it would be preferable to have a more thorough separation.

@neuecc neuecc merged commit 889dc5b into Cysharp:master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants