Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable (param string[] something) to accept arbitrary number of parameters. #90

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

igadmg
Copy link
Contributor

@igadmg igadmg commented Aug 23, 2022

For declaring some command like this
[Command("run", "Run commandlet.")] public async Task RunCommandlet([Option(0)] string commandlet, [Option(1)] params string[] parameters)
if last indexed parameter is params then it will accept all leftover parameters from command line

For example myprog run CommandletName param1 param2 - param1 param2 will be put to parameters array
In case of myprog run CommandletName - parameters will be empty.

@neuecc
Copy link
Member

neuecc commented Sep 30, 2022

I think it's ok, I'll try to merge it, thanks.

@neuecc neuecc merged commit 4a19ccb into Cysharp:master Sep 30, 2022
neuecc added a commit that referenced this pull request Oct 5, 2022
@neuecc
Copy link
Member

neuecc commented Oct 5, 2022

@yatagarasu25
sorry, this feature was released in 4.2.3 but I've reverted in 4.2.4 because this test was failed.
815cad8
If this feature is needed, please modify the code and also add unit tests along with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants