New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnixDomainSocket feature to interprocess PubSub #61
Conversation
…omain flag MessagePipe.Unity/Assets/Plugins/MessagePipe/Runtime/SubscriberExtensions.FirstAsync.cs: why `GetResult` and `UnsafeGetStatus` appears twice?
duplicated method problem is fixed by #64 |
add following methods and classes to public.
|
I made benchmark between TCP/IP and TCP/UDS for PubSub and IRemoteRequestHandler, BenchmarkDotNet=v0.13.0, OS=Windows 10.0.19043.1081 (21H1/May2021Update)
Intel Core i7-4712MQ CPU 2.30GHz (Haswell), 1 CPU, 8 logical and 4 physical cores
.NET SDK=6.0.100-preview.5.21302.13
[Host] : .NET 5.0.7 (5.0.721.25508), X64 RyuJIT
ShortRun : .NET 5.0.7 (5.0.721.25508), X64 RyuJIT
Job=ShortRun IterationCount=3 LaunchCount=1
WarmupCount=3
|
I forget to add some unittests, please wait |
fixed |
I found redundant wait in benchmark, so I re-run benchmark, here is the result. BenchmarkDotNet=v0.13.0, OS=Windows 10.0.19043.1081 (21H1/May2021Update)
Intel Core i7-4712MQ CPU 2.30GHz (Haswell), 1 CPU, 8 logical and 4 physical cores
.NET SDK=6.0.100-preview.5.21302.13
[Host] : .NET 5.0.7 (5.0.721.25508), X64 RyuJIT
ShortRun : .NET 5.0.7 (5.0.721.25508), X64 RyuJIT
Job=ShortRun IterationCount=3 LaunchCount=1
WarmupCount=3
|
thanks for the nice PR. |
Sorry for the extremely delay to merge. |
In some cases,unix domain socket may be more efficient than IP socket(especially linux).
I think I must resolve following problems for review
GetResult
andUnsafeGetStatus
appears twice insrc/MessagePipe.Unity/Assets/Plugins/MessagePipe/Runtime/SubscriberExtensions.FirstAsync.cs