Added a test for joining HashSet values. #84
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test for joining HashSet values.
It fails because the overload
Join<T>(string separator, params T[] values)
is used, even though there exists overloads for bothJoin<T>(string separator, ICollection<T> values)
andJoin<T>(char separator, IEnumerable<T> values)
I cannot explain this, haven't dived deeper into this.
The fix is easy, add another overload, but I am not sure how you want to handle this.
Is it a bug in the framework? Will it affect other types?
If it is just another overload, I can easily include the fix in the pull request.
In my code I just cast it to IEnumerable<> and it works.