Allow recording software to capture audio #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm this isn't an issue for me on my OnePlus 7 Pro. My captured audio works fine using the built-in screen recorder. What device are you using? |
It is for Android Q's official recorder provided by Google and which need this to reecord the audio. |
|
I've been testing on a Pixel 2 running android 10, but I've found the simplest way to test if an app allows recording is to use https://github.com/rom1v/sndcpy to try and forward the audio to a connected PC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://developer.android.com/guide/topics/media/playback-capture, this allows cytoid's audio to be recorded by other apps on the device. This is useful both for people who want to quickly record gameplay, and people using tools such as sndcpy to mirror their device's audio. I have not tested a full build (as I lack the required unity plugins) however I have patched this change into a production build with success.