Move YAML document separator to top of release manifests (GoogleCloud…

…Platform#799)

Move the YAML document separator inserted as part of `make-release-artifacts.sh` to the top of each manifest rather than the bottom.

Having the separator at the end of the manifest results in the generated release YAML files containing an empty document at the end. Whilst this is valid YAML, it is untidy, and certain YAML tools (`yq`) have been seen to handle empty document elements badly.

hack/make-release-artifacts.sh

@@ -51,12 +51,12 @@ read_manifests() {
     dir="$1"
 
     while IFS= read -d $'\0' -r file; do
+        echo "---"
+
         # strip license headers (pattern "^# ")
         awk '
         /^[^# ]/ { found = 1 }
         found { print }' "${file}"
-
-        echo "---"
     done < <(find "${dir}" -name '*.yaml' -type f -print0)
 }