Fixes Issue 2452 - Better diagnostic on unimplemented interface.

dlang · Jan 20, 2013 · 89543ab · 89543ab
1 parent 2102028
commit 89543ab
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/class.c b/src/class.c
@@ -1653,6 +1653,7 @@ int BaseClass::fillVtbl(ClassDeclaration *cd, FuncDeclarations *vtbl, int newins
         assert(ifd);
         // Find corresponding function in this class
         tf = (ifd->type->ty == Tfunction) ? (TypeFunction *)(ifd->type) : NULL;
+        assert(tf);  // should always be non-null
         fd = cd->findFunc(ifd->ident, tf);
         if (fd && !fd->isAbstract())
         {
@@ -1676,8 +1677,10 @@ int BaseClass::fillVtbl(ClassDeclaration *cd, FuncDeclarations *vtbl, int newins
             //printf("            not found\n");
             // BUG: should mark this class as abstract?
             if (!cd->isAbstract())
-                cd->error("interface function %s.%s isn't implemented",
-                    id->toChars(), ifd->ident->toChars());
+                cd->error("interface function %s.%s%s isn't implemented",
+                    id->toChars(), ifd->ident->toChars(),
+                    Parameter::argsTypesToChars(tf->parameters, tf->varargs));
+
             fd = NULL;
         }
         if (vtbl)

diff --git a/test/fail_compilation/diag2452.d b/test/fail_compilation/diag2452.d
@@ -0,0 +1,17 @@
+/*
+TEST_OUTPUT:
+---
+fail_compilation/diag2452.d(14): Error: class diag2452.C interface function I.f(float p) isn't implemented
+---
+*/
+
+interface I
+{
+    void f(int p);
+    void f(float p);
+}
+
+class C : I
+{
+    void f(int p) { }
+}