Merge pull request #2289 from 9rnsr/fix10506

Issue 10506 - Purity should not be checked in a mixin statement
dlang · Jul 5, 2013 · d16ce29 · d16ce29
2 parents 11d22d6 + 075f1ec
commit d16ce29
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/src/expression.c b/src/expression.c
@@ -2201,7 +2201,7 @@ void Expression::checkPurity(Scope *sc, FuncDeclaration *f)
             f->parent->isTemplateInstance()->enclosing == NULL)
         {   // The closest pure parent of instantiated non-nested template function is
             // always itself.
-            if (!f->isPure() && outerfunc->setImpure())
+            if (!f->isPure() && outerfunc->setImpure() && !sc->needctfe)
                 error("pure function '%s' cannot call impure function '%s'",
                     outerfunc->toPrettyChars(), f->toPrettyChars());
             return;

diff --git a/src/traits.c b/src/traits.c
@@ -584,8 +584,10 @@ Expression *TraitsExp::semantic(Scope *sc)
             unsigned errors = global.startGagging();
             unsigned oldspec = global.speculativeGag;
             global.speculativeGag = global.gag;
-            bool scSpec = sc->speculative;
+            sc = sc->push();
             sc->speculative = true;
+            sc->needctfe = 0;
+            sc->flags = sc->enclosing->flags;   // inherit
 
             Type *t = isType(o);
             if (t)
@@ -606,7 +608,7 @@ Expression *TraitsExp::semantic(Scope *sc)
                 }
             }
 
-            sc->speculative = scSpec;
+            sc = sc->pop();
             global.speculativeGag = oldspec;
             if (global.endGagging(errors))
             {

diff --git a/test/runnable/xtest46.d b/test/runnable/xtest46.d
@@ -2651,6 +2651,23 @@ void test6169() pure @safe
     enum z = ctfefptr6169();
 }
 
+/***************************************************/
+// 10506
+
+void impureFunc10506() {}
+string join10506(RoR)(RoR ror)
+{
+    impureFunc10506();
+    return ror[0] ~ ror[1];
+}
+
+void test10506() pure
+{
+    void foobar() {}
+
+    mixin(["foo", "bar"].join10506()~";");
+}
+
 /***************************************************/
 
 const shared class C5107