Merge pull request #4667 from Kozzi11/14596

fix Issue 14596 - Error: e2ir: cannot cast malloc(42u) of type void* …
dlang · May 19, 2015 · d872b5a · d872b5a
2 parents bd25986 + 2bcf5dc
commit d872b5a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/cast.c b/src/cast.c
@@ -1510,6 +1510,12 @@ Expression *castTo(Expression *e, Scope *sc, Type *t)
             {
                 goto Lfail;
             }
+            // Bugzilla 14596: Tpointer --> T(s)array
+            if ((tob->ty == Tarray || tob->ty == Tsarray) && t1b->ty == Tpointer)
+            {
+                goto Lfail;
+            }
+
             // Bugzilla 10646: Tclass <--> (T[] or T[n])
             if (tob->ty == Tclass && (t1b->ty == Tarray || t1b->ty == Tsarray) ||
                 t1b->ty == Tclass && (tob->ty == Tarray || tob->ty == Tsarray))

diff --git a/test/fail_compilation/fail_casting.d b/test/fail_compilation/fail_casting.d
@@ -178,3 +178,17 @@ void test14093()
     Tuple14093!(int, "x", int, "y") point;
     auto newPoint = cast(Object)(point);
 }
+
+/*
+TEST_OUTPUT:
+---
+fail_compilation/fail_casting.d(192): Error: cannot cast expression p of type void* to char[]
+fail_compilation/fail_casting.d(193): Error: cannot cast expression p of type void* to char[2]
+---
+*/
+void test14596()
+{
+    void* p = null;
+    auto arr = cast(char[])p;
+    char[2] sarr = cast(char[2])p;
+}