Implemented feature 767 (ready for review & pull)

[eskimor]

http://d.puremagic.com/issues/show_bug.cgi?id=767

Implemented -deps switch without an '=file' it prints dependencies to stdout. For module imports the format is the same as for -deps=file, but the line is prefixed with depsImport.

The following dependencies are printed:
depsVersion Any version() found (except standard ones and ones set in the module itself)
depsImport Any imports found (same as -deps=file output, except prefixed with depsImport)
depsFile Any file imports found
depsLib Any libraries specified with pragma(lib)
depsDebug Any debug() statements found (except the ones set in the module itself)

The format is extensible, as additional dependencies can be easily added by providing some new prefix depsFOO. Tools can easily grasp what is dependency information, because every line starts with "deps".

This patch is needed for tools like dub for reliable and efficient builds.

[eskimor]

Based on feedback on IRC: Dropped -filedeps, instead recycled -deps. If no file is specified, print to stdout in the format explained in the commit message. (Compatible to -v output)

issue 767 is now fully implemented and a bit more.

[eskimor]

Any feedback? If you as a maintainer don't like it, please just tell me. Knowing that it won't be accepted is still better than waiting forever. If it looks good to you but you haven't found the time yet to proof read it, please also just leave a short comment.

I am also very willing to improve this patch in any possible way, just tell me.

I would really like to improve dub based on this feature, but I need to know whether it is going to be accepted or not.

[nazriel]

@eskimor , this is very good work.
You need to be patience though.
Until recently, some pull requests were hanging for even a year, before they were merged.
Situation is better now, but still takes some time ;)

[eskimor]

@eskimor , this is very good work.

:-) Thanks a lot!

You need to be patience though.
Until recently, some pull requests were hanging for even a year, before they were merged.

That's exactly what scared me :-) I guess I'll start with some dub improvements, that do not depend on this.

Thanks again for your feedback, I really appreciate it.

[andralex]

why the extra whitespace?

[andralex]

there should be sample flags usage and output in the comments

[timotheecour]

Why not use json output instead of a custom one

(Every active import from a module will be printed like this: "bldinfo import: %s("%s") => %s("%s")", moduleFQN, moduleFileName,importedModuleFQN, importedModuleFileName)

It'll make it easier to parse

[dnadlinger]

Apart from the points brought up above, this needs test cases!

[eskimor]

I hope I got all whitespace issues. I'll take care of explanatory comments asap.
@timotheecour I kept the format which was used in -deps=filename, thought this might be good. Not sure if JSON really helps for something that simple.
@klickverbot Ok, I'll check out the testing infrastructure and fiddle something together.

Thank you guys!

[dnadlinger]

@eskimor: Yep, I'd just check out some of the existing test cases that validate the compiler output (DDoc, JSON, …) and adapt it for this purpose.

[eskimor]

@timotheecour Also the output is to stdout, so the Json would be mixed into other output.

[eskimor]

Thanks @klickverbot for the hint :-) Before I forget again, I needed the helper routine 'escapePath()' in more than one place, so I simply moved it into mars.h/c. Is this the right place for general helper functions or is there a better one?