Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Align -deps command line usage with rest of output #2238

Merged
1 commit merged into from Jun 21, 2013

Conversation

brad-anderson
Copy link
Member

Shortened it a bit too.

@ghost
Copy link

ghost commented Jun 21, 2013

I'd really shorten it even more:

print module dependencies (imports/file/version/debug/lib)

That way it doesn't wrap to the next line. This line was way too long anyway.

@@ -349,7 +349,7 @@ void usage()
-debug=ident compile in debug code identified by ident\n\
-debuglib=name set symbolic debug library to name\n\
-defaultlib=name set default library to name\n\
-deps write module import dependencies to stdout. (All dependencies including file/version/debug/lib)\n\
-deps write module import dependencies to stdout (including file/version/debug/lib)\n\
-deps=filename write module dependencies to filename (only imports - deprecated)\n%s\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really part of the pull request, but I wonder why writing to file is depecrated. I think writing to stdout is useless for tools because any other output can break the tools (e.g. pragma(msg,"import abc").

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was deprecated because the recently added -deps without filename (added by #1839) offers a lot more and was meant to replace it. That's just a guess though. It does prefix its output which should help with parsing it at least.

@brad-anderson
Copy link
Member Author

@AndrejMitrovic Changed to your suggestion.

ghost pushed a commit that referenced this pull request Jun 21, 2013
[trivial] Align -deps command line usage with rest of output
@ghost ghost merged commit 3fb7805 into dlang:master Jun 21, 2013
@ghost
Copy link

ghost commented Jun 21, 2013

Thanks.

@brad-anderson brad-anderson deleted the patch-1 branch June 21, 2013 17:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants