[REG2.063] Disable enhancement feature 7444 #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing issues: http://d.puremagic.com/issues/show_bug.cgi?id=11276 To enforce slice + assign syntax `a[] = b[]` may cause problems with generic code. http://d.puremagic.com/issues/show_bug.cgi?id=11244 A case yet difficult to make it clear - combination with operator overloading.
ghost
mentioned this pull request
|
Thanks, this also fixes the msgpack issue. What's most problematic is not knowing which code causes the diagnostic, since the diagnostic is emitted inside of Phobos. |
WalterBright
added a commit
that referenced
this pull request
Oct 20, 2013
[REG2.063] Disable enhancement feature 7444
WalterBright
added a commit
that referenced
this pull request
Oct 20, 2013
[REG2.063] Disable enhancement feature 7444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enhancement 7444 has been introduced in 2.063. But now, there's some issues which are not easy to immediately resolve.
I'd suggest to disable the feature 7444 in 2.064 release.
Existing issues:
Issue 11276 - Spurious "explicit slice assignment ...[] is better" warning message in Phobos
To enforce slice + assign syntax
a[] = b[]may cause problems with generic code.Issue 11244 - Invalid warning about slice assignment
A case yet difficult to make it clear - combination with operator overloading.