fix Issue 13138 add peek/poke to core.bitop #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull this one before the druntime one, so the autotester can work. |
|
This is essentially DIP20 (http://wiki.dlang.org/DIP20) |
|
Yes, that's right. I updated bugzilla to reflect this. |
|
Shouldn't there be some accompanying documentation for this in the spec and/or library reference? |
|
It's in the documentation in the druntime PR. |
| @@ -329,6 +329,12 @@ if (I32) assert(tysize[TYnptr] == 4); | |||
| ep->Eoper = op; | |||
| ep->Ety = tyret; | |||
| e = ep; | |||
| if (op == OPeq) | |||
| { /* This was a poke(ptr, value) operation, rewrite as: | |||
There was a problem hiding this comment.
Comment needs updating to the new name.
|
Auto-merge toggled on |
|
Obviously trusting you on the backend/glue layer details, but seems sensible. |
dnadlinger
added a commit
that referenced
this pull request
Jul 20, 2014
fix Issue 13138 add peek/poke to core.bitop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13138
Requires dlang/druntime#892