Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "accept @pure @nothrow @return attributes" #4349

Merged
merged 1 commit into from Jan 28, 2015
Merged

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Jan 27, 2015

Reverts #4341

@andralex
Copy link
Member

Please let's wait for a closure of the forum discussion. Thanks!

@dnadlinger
Copy link
Member

@andralex: Why this way instead of the usual "revert first, discuss fix later"?

@WalterBright
Copy link
Member

Because I don't want to wind up reverting the revert.

@dnadlinger
Copy link
Member

What's so bad about that? Would you feel the same if it wasn't your own change?

@9rnsr
Copy link
Contributor Author

9rnsr commented Jan 28, 2015

Because I don't want to wind up reverting the revert.

It's not an issue. After the syntactic sugar is actually approved by the community, we can add it again.

@9rnsr
Copy link
Contributor Author

9rnsr commented Jan 28, 2015

Auto-merge toggled on

9rnsr added a commit that referenced this pull request Jan 28, 2015
@9rnsr 9rnsr merged commit 430bdba into master Jan 28, 2015
@andralex
Copy link
Member

I understand and approve; just as a matter of procedure let's have in the future a different person than the pull creator merge it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants