Issue 7105 - relax inout rules #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4959,6 +4963,9 @@ int Type::covariant(Type *t, StorageClass *pstc) | |||
| // BUG: cannot convert ref to const to ref to immutable | |||
| // We can add const, but not subtract it | |||
| if (arg2->type->implicitConvTo(arg1->type) < MATCHconst) | |||
| #else | |||
| // Allow contravariant for only inout parameters, see bug 7542. | |||
| if (!(arg2->type->hasWild() && arg1->type->wildConvTo(arg2->type))) | |||
There was a problem hiding this comment.
This breaks the type system.
There was a problem hiding this comment.
Thanks for your pointing out. I'll remove changes for 7542 and 7543.
WalterBright
added a commit
that referenced
this pull request
Feb 19, 2012
Issue 7105 - relax inout rules
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Fix win32.mak clean target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 7105 - relax inout rules
Now bug 5493 and bug 4251 was fixed, so inout function doesn't have inout return type works properly without breaking type system. So, there is no faults to do this.
Issue 7542 - inout parameter contravariant should be allowed Issue 7543 - inout opApply should work properlyAfter relaxing inout rules, we can write useful inout opApply with delegate parameter that receives inout, and it should work properly. Supporting it will increase usefullness of inout type system.