ABC Improvements #818
Merged
ABC Improvements #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleans up state when going from Hatch -> Open Various spell-checking fixes
I think it's important for an existing token to be supported by an ABC. Token DAO's will be able to set up liquidity more easily by simply allowing mint & burn functionality after instantiating the ABC while holding ownership of it. *Also adds a query for hatcher allowlist *fixes spell checks I ran into *moves TokenInfo from dao-voting-token-staked to dao-interface for use in cw-abc
JakeHartnell
reviewed
Apr 7, 2024
Renamed fees_recipient to funding_pool_forwarding for better naming Made funding_pool_forwarding optional Allow updating the funding_pool_forwarding by owner Allow withdrawing from the funding pool by owner
Adds IS_PAUSED state that is checked in execute entry Also fixes naming in commands
Also fixes donation state being lost after multiple donations
Could use a test here Also fixes some warnings and flag for cw-std
also reorg buy command to be closer to sell command for readability
Derive copy on DecimalPlaces Catch OverflowError directly in ContractError Do not set initial supply as supply - will further remove allowing initial supplies
|
Running |
Also removes unused deps from cw-abc which now live in cw-curves
|
Shoutout to @BHIIKTOR btw for noticing unnecessary packages and aliases after moving things to cw-curves package |
|
I still want to squeeze in a couple of things.
|
Let users know the curve state and returned amount after x payment
Disallow selling in the hatch phase Do not validate max_contribution against max_raise
also clippy fixes
|
this is ready 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#697 Extension of this PR