Augmented Bond Curves #697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doing G-d's work, Ser! 👏 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## development #697 +/- ##
===============================================
- Coverage 93.97% 91.64% -2.34%
===============================================
Files 62 68 +6
Lines 5596 5962 +366
===============================================
+ Hits 5259 5464 +205
- Misses 337 498 +161
☔ View full report in Codecov by Sentry. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #697 +/- ##
===============================================
- Coverage 96.25% 94.85% -1.40%
===============================================
Files 203 212 +9
Lines 50082 51289 +1207
===============================================
+ Hits 48207 48651 +444
- Misses 1875 2638 +763
☔ View full report in Codecov by Sentry. |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
For the Probably some useful stuff in there. Would be nice to have a solid curves package. |
* CwAbcResult * Hatch phase configuration and init msg refactor * Initial instantiate test * Implement separate phrases and phrase configs * Remove vesting phase and update funding pool * Separate commands and queries * Update init msg with string configs * Phase config query * MinMax and config query * Add some todos * cw-ownable integration
* Separate hatcher allowlist * Donation feature * Initial sell exit tax * Hatchers to amount * Hatch phase exit tax * TokenMsg methods * Format * Hatchers query * Fix bug where float was not taken into account in supply * Buy and sell refactoring * Update hatch phase config * Update phase config enum * Add adairrr to authors * Initial boot integration with custom msgs * Initial testing infrastructure * Abstract-OS to AbstractSDK
Creates new cw-abc DAOs.
ismellike
reviewed
Apr 7, 2024
| /// Update the hatch phase configuration | ||
| Hatch { | ||
| contribution_limits: Option<MinMax>, | ||
| // TODO what is the minimum used for? |
There was a problem hiding this comment.
I think paired with an expiration, the minimum could be used to determine if the ABC Hatch phase was successful.
If expired and the minimum was not met, then the ABC goes into the Closed phase. If expired with the minimum met, then the ABC goes into the Open phase.
* Make hatcher_allowlist a map Also cleans up state when going from Hatch -> Open Various spell-checking fixes * Allow existing tokens to be used with ABC's I think it's important for an existing token to be supported by an ABC. Token DAO's will be able to set up liquidity more easily by simply allowing mint & burn functionality after instantiating the ABC while holding ownership of it. *Also adds a query for hatcher allowlist *fixes spell checks I ran into *moves TokenInfo from dao-voting-token-staked to dao-interface for use in cw-abc * Complete funding pool logic Renamed fees_recipient to funding_pool_forwarding for better naming Made funding_pool_forwarding optional Allow updating the funding_pool_forwarding by owner Allow withdrawing from the funding pool by owner * Implement a circuit breaker Adds IS_PAUSED state that is checked in execute entry Also fixes naming in commands * Add query for initial supply at ABC creation * Allow donation into the reserve pool Also fixes donation state being lost after multiple donations * Move cw-abc curves to its own package cw-curves * Improve validation for max_supply * Support DAO membership in hatcher allowlist Could use a test here Also fixes some warnings and flag for cw-std * Clippy fix * Only clone decimals from curve_state also reorg buy command to be closer to sell command for readability * QoL improvements Derive copy on DecimalPlaces Catch OverflowError directly in ContractError Do not set initial supply as supply - will further remove allowing initial supplies * Revert support for initial supply * Fix clippy unnecessary clones * Donate only into the funding pool * Add a test for donate and withdraw from funding pool * Add test for dao hatchers + update schemas Also removes unused deps from cw-abc which now live in cw-curves * Update Cargo.toml * Buy & Sell Quotes Let users know the curve state and returned amount after x payment * Complete DAO hatchers w/ priority queue Disallow selling in the hatch phase Do not validate max_contribution against max_raise * Fix priority queue ordering on ties also clippy fixes * Couple more clippy fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABCs are cool! This will try and implement much of what is in this excellent blog post.
To do:
experimentalfolderBonus:
cw-curvespackage