-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds parent pointer storage + fork display in the UI #189
Conversation
TODO:
|
776d7cf
to
2786614
Compare
This way we can know that an application was forked + link to it.
This tests that we store + serialize parent pointers. There are a few edge-cases we should probably handle (nulling out/tracking the sequence ID, for example), but this is the 80/20 for now.
994acb5
to
b780f16
Compare
This is a bit ugly, but its a placeholder for a much cleaner future refactor. I stand by haviung types.py here so we can centralize future ones, even though only ParentPointer is there now.
parent_pointer=burr_types.ParentPointer( | ||
app_id=self.fork_from_app_id, | ||
partition_key=self.fork_from_partition_key, | ||
sequence_id=self.fork_from_sequence_id, | ||
) | ||
if self.loaded_from_fork | ||
else None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay here. It could be all in that one method though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the diff here? did you just run the notebook? or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, will remove
@@ -81,6 +82,21 @@ def from_transition(transition: Transition) -> "TransitionModel": | |||
) | |||
|
|||
|
|||
class PointerModel(IdentifyingModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a short comment would help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't tested, but looks fine on first glance.
b9899ac
to
08cea4e
Compare
This way we can know that an application was forked + link to it.
See #185.
Changes
Fork information is stored so we know parent pointers + can make debugging easier.
How I tested this
Manually, will add testing
Checklist