-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polaris JSON Read Writer, Unit Test, Materilization. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrawcz
reviewed
Oct 5, 2023
skrawcz
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question on the import -- otherwise looking good thanks!
skrawcz
reviewed
Oct 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good. Will add my minor adjustment, and will merge. Thanks!
We should always have file passed because it does not make sense to return a string value instead of writing to file here.
skrawcz
reviewed
Oct 8, 2023
skrawcz
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- PR TEMPLATE INSTRUCTIONS (1) ---
PR is regarding issue
Looking to submit a Hamilton Dataflow to the sf-hamilton-contrib module? If so go the the
Preview
tab and select the appropriate sub-template:Else, if not, please remove this block of text.
--- PR TEMPLATE INSTRUCTIONS (2) ---
Polars JSON read/write
Changes
Polaris JSON Read Writer, Unit Test, materializations
How I tested this
unit test and materializations
Notes
Checklist