Fixes to the DAG path visualizations #518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The viz would display the set of nodes + their immediate parents. The driver function would only pass the "nodes on the path" and have the viz draw the parents.
This caused an issue because nodes not explicitly passed didn't received styling. Instead, they were implicitly created when trying to create to them.
Changes
There are 3 sets of changes:
strictly_display_only_passed_in_nodes=True
and handles the nodes to pass at the Driver level (i.e., includes the parents explicitly).How I tested this
The existing test suite still works. Changes only affect how the set of node is passed from the Driver to the
create_graphviz_graph()
function and how nodes / edges are displayed.Notes
Checklist