Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the DAG path visualizations #518

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Fixes to the DAG path visualizations #518

merged 3 commits into from
Nov 8, 2023

Commits on Nov 7, 2023

  1. Fixes to the DAG path visualizations

    There are 3 sets of changes:
    1. Create_graphviz_graph(): added logic to highlight path in red
    2. Driver visualizations: expose the new params (show_legend, orient, hide_inputs, deduplicate_inputs) to all visualization functions
    3. Path visualizations (between, upstream, downstream): previously, the viz would display the set of nodes + their immediate parents. The driver function would only pass the "nodes on the path" and have the viz draw the parents. This caused an issue because nodes not explicitly passed didn't received styling. Instead, they were implicitly created when trying to create to them. The changes force the parameter strictly_display_only_passed_in_nodes=True and handles the nodes to pass at the Driver level.
    zilto authored and zilto committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    872ed36 View commit details
    Browse the repository at this point in the history
  2. Updates lineage example

    To use new rendering.
    skrawcz committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    330d65f View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Updates hello world and readme images

    So that they now match the new way things are rendered.
    skrawcz committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8e4c320 View commit details
    Browse the repository at this point in the history