Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastAPI integration page #645

Merged
merged 4 commits into from
Jan 17, 2024
Merged

FastAPI integration page #645

merged 4 commits into from
Jan 17, 2024

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Jan 17, 2024

Added a page about FastAPI under docs/integration

Changes

  • fastapi.md page
  • 2 visualizations in the folder

How I tested this

  • built the docs locally

Notes

  • the merge conflict is because I created the branch before the new Streamlit page was added to the integration index.

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Jan 17, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Jan 17, 2024 •
edited
Loading

Sweeping

Resolving merge conflicts: track the progress here.

I'm currently resolving the merge conflicts in this PR. I will stack a new PR once I'm done.

✨ Created Pull Request: #646

@sweep-ai sweep-ai bot mentioned this pull request Jan 17, 2024
Closed
skrawcz
skrawcz approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - suggested some edits

@zilto zilto merged commit 6f6edb3 into main Jan 17, 2024
22 checks passed
@zilto zilto deleted the docs/fastapi-integration branch January 17, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zilto @skrawcz