Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes skipif logic #778

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Fixes skipif logic #778

merged 2 commits into from
Mar 22, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Mar 22, 2024

Argh, didn't properly evaluate the condition.
This should work now.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Fixes skipif logic
5cc3e0f 
Argh, didn't properly evaluate the condition.
This should work now.
@skrawcz
Fixes isort issue by skipping it
1186c3b 
Pre-commit run --all-files still has different behavior
than the pre-commit hook for me. This just tells isort
to skip things. I'm not sure where the discrepancy comes from.
@skrawcz skrawcz merged commit 8689202 into main Mar 22, 2024
17 of 23 checks passed
@skrawcz skrawcz deleted the skip_polars_test branch March 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@skrawcz