Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes skipif logic #778

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Fixes skipif logic #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cc3e0f
Fixes skipif logic
skrawcz Mar 22, 2024
1186c3b
Fixes isort issue by skipping it
skrawcz Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
exclude: '^docs/code-comparisons/' # skip the code comparisons directory
repos:
- repo: https://github.com/ambv/black
rev: 24.1.1
rev: 24.3.0
hooks:
- id: black
args: [--line-length=100, --exclude=docs/*]
Expand Down
4 changes: 3 additions & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ ignore =
W605

[isort]
known_first_party=hamilton
profile=black
known_local_folder=tests
known_first_party=hamilton
skip=docs
line_length=100

[black]
line-length = 100
Expand Down
11 changes: 7 additions & 4 deletions tests/plugins/test_polars_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import pathlib
import sys

import pytest
import polars as pl # isort: skip
import pytest # isort: skip

import polars as pl
from hamilton.plugins.polars_extensions import (
from hamilton.plugins.polars_extensions import ( # isort: skip
PolarsAvroReader,
PolarsAvroWriter,
PolarsCSVReader,
Expand Down Expand Up @@ -120,7 +120,10 @@ def test_polars_avro(df: pl.DataFrame, tmp_path: pathlib.Path) -> None:
assert df.frame_equal(df2)


@pytest.mark.skipif(sys.version_info == (3, 12), reason="weird connectorx error on 3.12")
@pytest.mark.skipif(
sys.version_info.major == 3 and sys.version_info.minor == 12,
reason="weird connectorx error on 3.12",
)
def test_polars_database(df: pl.DataFrame, tmp_path: pathlib.Path) -> None:
conn = f"sqlite:///{tmp_path}/test.db"
table_name = "test_table"
Expand Down