Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests and add CI #51

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Refactor tests and add CI #51

merged 5 commits into from
Jun 7, 2023

Conversation

Yiling-J
Copy link
Collaborator

@Yiling-J Yiling-J commented Jun 4, 2023

  • move all tests to txdb_test package
  • refactor tests, make it easy to add more drivers
  • enable github action CI for mysql & postgresql
  • fix some lint warnings

@Yiling-J Yiling-J mentioned this pull request Jun 4, 2023
Open
stefafafan
stefafafan reviewed Jun 4, 2023
View reviewed changes
Copy link
Collaborator

@stefafafan stefafafan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks okay, just a few comments on the GitHub Actions file.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
stefafafan
stefafafan approved these changes Jun 4, 2023
View reviewed changes
Copy link
Collaborator

@stefafafan stefafafan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me!

@Yiling-J
Copy link
Collaborator Author

Yiling-J commented Jun 4, 2023 •
edited
Loading

Thanks, it looks good to me!

Cool! Let's wait @l3pp4rd to review and invite you as collaborator

@l3pp4rd l3pp4rd self-requested a review June 7, 2023 12:37
l3pp4rd
l3pp4rd approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@l3pp4rd l3pp4rd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@Yiling-J Yiling-J merged commit a4f1df7 into DATA-DOG:master Jun 7, 2023
@stefafafan stefafafan mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3pp4rd l3pp4rd l3pp4rd approved these changes

@stefafafan stefafafan stefafafan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yiling-J @l3pp4rd @stefafafan