[nit] Set psql/mysql passwords to match Makefile, so make test works
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
password was set here ( b7e1748 ) but the docker-compose.yml file remained to have an empty password
stefafafan
changed the title
make test works
Yiling-J
approved these changes
Jun 7, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #51
To run tests on a local machine with Docker, the command below was originally working
$ docker compose up $ make test#51 set a password explicitly for mysql/psql in the Makefile, which made
make testfail.I went ahead and adjusted the docker-compose.yml so the password matches the Makefile. Now the tests pass locally.
$ make test ... INSERT 0 3 Opening db... Opening db... PASS ok github.com/DATA-DOG/go-txdb 0.626s