shelob: changes to where internal things are served #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read on: - /status is still served on the regular web port, but is only served if there are no applications deployed that matches the input host header - /api/applications and the html applications view (served on /) is moved the the admin port - /metrics are now only served on the admin port the check "routeToSelf" that previously special-cased the host header "localhost" has been removed.
srhb
approved these changes
Nov 21, 2019
adamtulinius
approved these changes
Nov 21, 2019
|
I (re-)investigated the possibility of a solution where the status endpoint has it's own "vhost", requiring a special host-header to get the status-response: It would require:
If all of the above are implemented, I think that solution has the potential for being nicer, than the current one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read on:
the check "routeToSelf" that previously special-cased the host header "localhost" has been removed.