ENH: Fieldmap selection #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reliable. The indenting in the previous version was strange, and I think testing for success may have been wrong in some cases, in that warnings about failure could be issued before the search was complete. dcm2bids doesn't create lists for the IntendedFor field when a single target is provided. This breaks the original tests, which used a ' '.join syntax and thus created strings separated by spaces when provided with a string. This meant the correct field map was never found. I have forced the result into a list if it isn't already, fixed the indenting and corrected the test for success. The join option could be used because it allows paths without a session field to be matched as substrings. Recent versions of dcm2bids include the session field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indenting in the previous version was strange, and I think
testing for success may have been wrong in some cases, in that
warnings about failure could be issued before the search was
complete.
dcm2bids doesn't create lists for the IntendedFor field when
a single target is provided. This breaks the original tests,
which used a ' '.join syntax and thus created strings
separated by spaces when provided with a string. This
meant the correct field map was never found.
I have forced the result into a list if it isn't already, adjusted the
indenting and modified the failure test.
The join option could be used because it allows paths without
a session field to be matched as substrings.
Recent versions of dcm2bids include the session field.