-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore name of loadable module, update extension category #16
Conversation
I am not sure I understand. Why do you want to revert the name? |
The name and category changes were initially only intended to be for SALT, not to be merged upstream. We can revert the name back to MFSDA for the version in the Slicer extension store if that is preferred. Keeping it under "Shape Analysis" instead of "Pvalue" probably makes sense though. |
Gotcha. Yes, that makes sense, will request that change. |
MFSDA/MFSDA_createShapes.xml
Outdated
@@ -1,6 +1,6 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<executable> | |||
<category>Shape Analysis.Advanced</category> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion in PR thread, lets keep this as Shape Analysis.
This commit partially reverts commit 4df8b7a (ENH: Rename modules for SALT) restoring the name of the loadable module from "Covariate Significance Testing" to "MFSDA"
@bpaniagua Please have another look 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muy bonito!
This reverts commit 4df8b7a.
MFSDA loadable module:
MFSDA
. it was changed toCovariate Significance Testing
.Pvalues
. It was changed toShape Analysis
For these two CLIs, the category is restored to
Pvalues
. It was changed toShape Analysis.Advanced
Questions
Should we keep the name of the loadable module to
Covariate Significance Testing
?Considering that MFSDA stands for
Multivariate Functional Shape Data Analysis
, is it sensible to keep the categoryShape Analysis
(instead of reverting back toPvalues
)?